Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Totem Of Corruption Overlay & Effective Area #1139

Merged
merged 23 commits into from
Mar 23, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Mar 10, 2024

What

This Pull Request adds a Totem Of Corruption Overlay, which includes the totem owner & the time left.
It also adds an option to hide the particles around the totem.
And it adds an effective area renderer, showing a sphere around the totem (Thank you Empa for figuring that out).
Also has an option to get reminded when the totem is about to run out (customiseable time)

Images

Overlay:
image
Effective Area:
image
Hidden Particles:
image

Changelog New Features

  • Added Totem Overlay. - j10a1n15
    • Option to change the overlay distance.
    • Option to hide Totem Particles.
    • Option to show the effective area of a totem.
    • Option to get reminded when a totem is about to expire.

Changelog Technical Details

  • Added drawSphereInWorld() method. - j10a1n15

@j10a1n15 j10a1n15 changed the title Feature: Totem Overlay & Effective Area Feature: Totem Of Corruption Overlay & Effective Area Mar 10, 2024
@hannibal002 hannibal002 added this to the Version 0.24 milestone Mar 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Mar 11, 2024
@hannibal002 hannibal002 added Soon This Pull Request will be merged within the next couple of betas and removed Soon This Pull Request will be merged within the next couple of betas labels Mar 16, 2024
@hannibal002 hannibal002 self-requested a review March 21, 2024 17:07
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see discord suggestions

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested in code, looks already pretty good

j10a1n15 and others added 5 commits March 21, 2024 19:57
…rruption.kt

Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
…rruption.kt

Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
@hannibal002 hannibal002 self-requested a review March 23, 2024 18:02
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool in game

@hannibal002 hannibal002 merged commit 44014aa into hannibal002:beta Mar 23, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Mar 23, 2024
@j10a1n15 j10a1n15 deleted the totem branch March 23, 2024 18:21
superhize pushed a commit to superhize/SkyHanni that referenced this pull request Apr 8, 2024
Co-authored-by: hannibal2 <24389977+hannibal002@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants