Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Widget abstractions #1150

Merged
merged 45 commits into from
Jun 3, 2024
Merged

Backend: Widget abstractions #1150

merged 45 commits into from
Jun 3, 2024

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Mar 12, 2024 •
edited
Loading

Dependencies

What

Wraps all widgets under an enum (I have a solution to update it remotely see 3b5edd8).
It also adds an widget update event that should reduce the usage of checking the whole tablist for every feature.

Widget info is also added to shcopytablist

Changelog Technical Details

  • Added Tab Widget abstraction. - Thunderblade73

@Thunderblade73 Thunderblade73 marked this pull request as ready for review March 12, 2024 19:39
@Thunderblade73
Copy link
Contributor Author

open to review but garden patterns are still missing. Since Garden is closed at the moment.

@Thunderblade73
Copy link
Contributor Author

@nea89o Would you mind taking a look at this PR and providing your feedback?

@hannibal002 hannibal002 added this to the Version 0.24 milestone Mar 12, 2024
@hannibal002 hannibal002 added Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Mar 13, 2024
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Mar 14, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@Thunderblade73
Merge branch 'beta' into widget
ba5af7c 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 22, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@hannibal002
Copy link
Owner

Is somethign already using this?

@Thunderblade73
Merge branch 'beta' into widget
6791720 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 23, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@jani270 jani270 added the Waiting on Dependency PR waiting for a dependency pr to be merged label May 7, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 31, 2024
@Thunderblade73
Merge branch 'refs/heads/beta' into widget
4413b86 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
#	src/main/java/at/hannibal2/skyhanni/utils/repopatterns/RepoPatternManager.kt
@Thunderblade73
updated
33340cc
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024

Conflicts have been resolved! 🎉

@jani270 jani270 removed the Waiting on Dependency PR waiting for a dependency pr to be merged label Jun 1, 2024
CalMWolfs
CalMWolfs approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

hannibal002
hannibal002 requested changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems:

Event too complex

The current system needs this workaround:

Image

image

(See #1977 for more info)

I'd suggest, we remove NewValues and Clear and instead fire Event(EnumType, List), with either changed values or an empty list if not found.

No event when no widget

Another problem is that the event is not getting sent when the widget is disabled when word switch. I don't want to assume the widgets are always disabled if the event is not sent (and then show an "open /tab and enable widget" display for the first second after world switch).

CalMWolfs
CalMWolfs approved these changes Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@hannibal002 hannibal002 merged commit 0d28849 into hannibal002:beta Jun 3, 2024
3 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nea89o nea89o nea89o requested changes

@CalMWolfs CalMWolfs CalMWolfs approved these changes

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
5 participants
@Thunderblade73 @hannibal002 @nea89o @CalMWolfs @jani270