Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Open Contest on elitebot.dev #1185

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

Obsidianninja11
Copy link
Contributor

@Obsidianninja11 Obsidianninja11 commented Mar 16, 2024

What

Adds a keybind to open a contest on elitebot.dev when clicking with the key held.
Also supports opening other contest pages on elitebot.dev such as upcoming, main page, and your contests.
Allows opening contests in calendar.

I realized after making this that this is a dupe of #915. I think my logic is a bit simpler, though.

Changelog New Features

  • Added Open On Elite. - Obsidian
    • Allow opening farming contest stats on elitebot.dev by pressing a keybind + mouse click onto a contest item.
    • Works inside the menus Jacob's Farming Contest, Your Contests, and SkyBlock Calendar.

@Obsidianninja11 Obsidianninja11 changed the title Open contest browser Feature: Open Contest on elitebot.dev Mar 16, 2024
@hannibal002 hannibal002 added this to the Version 0.24 milestone Mar 16, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Mar 16, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Can we change it to open on key click alone, not key press + mouse click?
Also maybe show the information "press to open this event in elite farming" in the item tooltip.

@Obsidianninja11
Copy link
Contributor Author

Can we change it to open on key click alone, not key press + mouse click?

Maybe add a toggle?
I like using ctrl+click for this

@Obsidianninja11
Copy link
Contributor Author

Obsidianninja11 commented Mar 17, 2024

Can we change it to open on key click alone, not key press + mouse click?

I didn't do this.
I don't like it that way.

@hannibal002 hannibal002 merged commit 3ca79ff into hannibal002:beta Apr 1, 2024
1 check passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 1, 2024
superhize pushed a commit to superhize/SkyHanni that referenced this pull request Apr 8, 2024
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
@Obsidianninja11 Obsidianninja11 deleted the open-contest-browser branch April 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants