Feature: Quiver Display #1190
Merged
Feature: Quiver Display #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster chestplate, and more patterns
Merged
…igration for it. also added support for kuudra to alert (temporary until i figure out how to properly do it)
|
Finished what i wanted to do with this (mostly), only thing left in my todo is merging the dungeon and kuudra enter/complete events into an instance event, but apart from that it should be ready for review. |
|
The description and names of the new configs also still have to be improved |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
# Conflicts: # src/main/java/at/hannibal2/skyhanni/data/QuiverAPI.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
requested changes
Apr 7, 2024
src/main/java/at/hannibal2/skyhanni/config/features/gui/GUIConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/gui/QuiverDisplayConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/gui/QuiverDisplayConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/gui/QuiverDisplay.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/gui/QuiverDisplay.kt
Outdated
Show resolved
Hide resolved
hannibal002
requested changes
Apr 10, 2024
src/main/java/at/hannibal2/skyhanni/features/gui/quiver/QuiverDisplay.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
Show resolved
Hide resolved
hannibal002
approved these changes
Apr 13, 2024
github-actions
bot
removed
the
Soon
Thunderblade73
pushed a commit
to Thunderblade73/SkyHanni
that referenced
this pull request
Apr 13, 2024
Co-authored-by: Cal <cwolfson58@gmail.com> Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Adds a Quiver Display that shows the amount of arrows you have, an alert to get after a dungeon/kuudra run if you ran out/are low on certain arrows, and a customizable amount to get that reminder and a low quiver notification. Also makes QuiverAPI use the item in the 9th slot of the hotbar to get more accurate numbers.
Images
TODO
Changelog New Features
Changelog Improvements
Changelog Technical Details
Changelog Removed Features