Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Architect Notifications when puzzle fails #1197

Merged
merged 11 commits into from
Apr 23, 2024

Conversation

Conutik
Copy link
Contributor

@Conutik Conutik commented Mar 16, 2024

What

Sends a title screen and a chat notification overwriting the one for puzzle fail, reminding the user to use an architect, and provides a button that can be clicked to retrieve it from sacks.

Demonstration https://conutik.catto.pics/748fad3b

Changelog New Features

  • Added notifications for architect on puzzle fail. - Conutik
    • Shows Title.
    • Shows button in chat to retrieve from sack.
    • Only works when having enough Architect First Drafts in the sack.

Changelog Technical Details

  • Fixed all regexes in DungeonCopilot.kt. - Conutik
    • Now uses RepoPattern with good key naming conventions.

@hannibal002 hannibal002 added this to the Version 0.24 milestone Mar 17, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this feature should be a sepearate feature outside of the dungeon co-pilot as afaik this feature is not fully finished and impacts performance a lot, I'll do further reviews once this is changed

@Conutik Conutik requested a review from CalMWolfs March 17, 2024 11:16
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still would like to see this fully separated from dungeon copilot, not needing that to be enabled to use this and that not being the pattern key.

Conutik and others added 2 commits March 19, 2024 15:44
…ngeonConfig.java

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Mar 24, 2024
@CalMWolfs CalMWolfs requested review from hannibal002 and removed request for CalMWolfs March 24, 2024 13:14
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested in game but I fixed the remaining issues with the code

@Conutik Conutik requested a review from CalMWolfs March 27, 2024 20:52
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not a fan of the repopattern key names. the dungeon chat messages should start with dungeon.chat.xyz, and not contain the feature name. we might add new features in the future that require the same chat messages, then the name is weird.

also for normal.puzzle.fail and quiz.puzzle.fail:
please rename to puzzle.fail.normal and puzzle fail.quiz

@Conutik Conutik requested a review from hannibal002 April 7, 2024 12:06
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the information what puzzle is failed, or disable this feature per default.

Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is fine. Adding the name of the puzzle is not necessary in my opinion since you could look that up via tab or simply know because of what player failed.

@hannibal002 hannibal002 self-requested a review April 23, 2024 20:43
@hannibal002 hannibal002 merged commit 2b8b4d9 into hannibal002:beta Apr 23, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants