Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Crystal Hollow Area Walls #1266

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Mar 24, 2024

What

Shows walls between the diffrent areas in the crystal hollows.

Images

2024-03-24_14 42 08
2024-03-24_14 40 48
2024-03-24_14 41 06
2024-03-24_14 41 08
2024-03-24_14 41 14
2024-03-24_14 41 31
2024-03-24_14 41 39

Why

To make it easier to stay in a single area while powder grinding.

Changelog New Features

  • Added Area Walls. - Thunderblade73
    • Show walls between the main areas of the Crystal Hollows.
    • Option to show the walls also when inside the Nucleus.

@hannibal002
Copy link
Owner

lf screenshots

@hannibal002 hannibal002 added this to the Version 0.25 milestone Mar 24, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Mar 24, 2024
@Thunderblade73
Copy link
Contributor Author

uploaded screenshots

Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of the code looks pretty good i think

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/utils/LorenzVec.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Conflicts have been resolved! 🎉

@Thunderblade73 Thunderblade73 requested a review from CalMWolfs April 3, 2024 19:21
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked

@hannibal002 hannibal002 merged commit 2d82935 into hannibal002:beta Apr 5, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 5, 2024
@Thunderblade73 Thunderblade73 deleted the crystal-hollows-walls branch April 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants