Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: No Bits Warning #1286

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Mar 26, 2024

What

Gives a warning when you have no more bits available to claim.

Changelog New Features

  • No Bits Available Warning. - Empa
    • Warns when you run out of available bits to generate.

Changelog Technical Details

  • Added BitsUpdateEvent. - Empa
  • Fixed default fame rank being null. - Empa

@hannibal002 hannibal002 added this to the Version 0.25 milestone Mar 27, 2024
@ItsEmpa ItsEmpa requested a review from CalMWolfs April 3, 2024 13:08
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Copy link

github-actions bot commented Apr 3, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Apr 3, 2024
@hannibal002 hannibal002 merged commit 704b90b into hannibal002:beta Apr 4, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 4, 2024
@ItsEmpa ItsEmpa deleted the no-bits-warning branch May 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants