Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Craftable Item List #1334

Merged
merged 43 commits into from
Jun 20, 2024
Merged

Feature: Craftable Item List #1334

merged 43 commits into from
Jun 20, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Apr 1, 2024

Depends on

Image

grafik

What

Add Craftable Items List.

Changelog New Features

  • Shows a list of items that can be crafted with the items in your inventory when inside the crafting menu. - hannibal2
    • Click on an item to open /recipe.
    • Option to include items from inside sacks.
    • Option to include vanilla items.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 1, 2024
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 1, 2024
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Conflicts have been resolved! 🎉

Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of this feature but right now the Include Sacks option needs some work. When enabling it i get a list that is 176 items long. (I also dont have much in my sacks or many sacks so for others it would be much more). It would be cool to have ways to sort this like we do for chest value. {price per (asc, desc) and amount craftable (asc, desc)} Also a way to "scroll" down that list if everything does not fit on the screen.

…raftableItemList.kt

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 1, 2024
Copy link

github-actions bot commented May 1, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 modified the milestones: Version 0.25, Version 0.26 May 1, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 13, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 28, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 28, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 30, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 16, 2024
@hannibal002
Copy link
Owner Author

The display now sorts by price per item, not multiplying per amount craftable.
Also, we allow scrolling now.

@hannibal002
Copy link
Owner Author

grafik

@hannibal002 hannibal002 merged commit 1a32e5e into beta Jun 20, 2024
9 checks passed
@hannibal002 hannibal002 deleted the crabable-item-list branch June 20, 2024 21:25
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants