Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add HUD element config links. #1383

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

nea89o
Copy link
Contributor

@nea89o nea89o commented Apr 7, 2024

Dependencies

What

Adds config links to positions in /sh edit. Simply right click on a config element to view it's associated config section.

Images

image

Changelog New Features

  • Added a link from HUD elements to config options. - nea
    • Simply right-click a HUD element in the HUD editor to jump to its associated options.
    • Does not yet work on every GUI element. Wait for the missing elements in the following betas.

This changes the package from being io.github.moulberry.moulconfig to
io.github.notenoughupdates.moulconfig. Before, there was a mix of both
package names, now it is just one. This will probably cause some merge
conflicts, but just running a global search/replace with those two will
fix almost all of them.

There are also some minor changes in the way ConfigProcessorDriver
works, it now takes a structure reader as constructor parameter.

Lastly some components have been rewritten. Notably the colour component
has been rewritten, but it should behave identically to before.

This is a beta version of moulconfig because some features are not fully
rewritten to be compatible with some of the new settings (like
stretching out descriptions, instead of scaling them down)
@jani270 jani270 added the Waiting on Dependency PR waiting for a dependency pr to be merged label Apr 7, 2024
@nea89o nea89o marked this pull request as ready for review April 7, 2024 21:58
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/ConfigManager.kt
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/composter/ComposterConfig.java
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/pests/SprayConfig.java
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

Copy link

github-actions bot commented Apr 8, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 8, 2024
@hannibal002 hannibal002 merged commit 878f8ee into hannibal002:beta Apr 8, 2024
3 checks passed
@github-actions github-actions bot removed the Waiting on Dependency PR waiting for a dependency pr to be merged label Apr 8, 2024
@nea89o nea89o deleted the poseditor branch April 8, 2024 16:47
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 8, 2024
@hannibal002 hannibal002 changed the title Add hud element config links. Improvement: Add HUD element config links. Apr 8, 2024
@hannibal002 hannibal002 changed the title Improvement: Add HUD element config links. Feature: Add HUD element config links. Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants