Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Profit Per Excavation #1439

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Feature: Profit Per Excavation #1439

merged 4 commits into from
Apr 15, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Apr 13, 2024

What

Add Profit Per Excavation.

Images ![image](https://github.com/hannibal002/SkyHanni/assets/24389977/6b6ef8bd-820d-4e21-b6df-21c6f6ffba5e)

Changelog New Features

  • Added Profit Per Excavation. - hannibal2
    • Show profit/loss in chat after each excavation.
    • Also include breakdown information on hover.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 13, 2024
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 13, 2024
@ItsEmpa
Copy link
Contributor

ItsEmpa commented Apr 13, 2024

shouldnt changelog say "Added" not adding

@ItsEmpa
Copy link
Contributor

ItsEmpa commented Apr 13, 2024

also whats up with it saying -12 coins for fossil dust

image

@hannibal002
Copy link
Owner Author

also whats up with it saying -12 coins for fossil dust

image

hypixel added a placeholder item, wow :O
image

@hannibal002 hannibal002 requested a review from j10a1n15 April 13, 2024 20:47
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, cant test

@hannibal002 hannibal002 merged commit 7943286 into beta Apr 15, 2024
7 checks passed
@hannibal002 hannibal002 deleted the profit-per-excavation branch April 15, 2024 16:54
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 15, 2024
@hannibal002 hannibal002 changed the title New Feature: Profit Per Excavation Feature: Profit Per Excavation Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants