Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow party members to request allinvite to be enabled #1464

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Feature: Allow party members to request allinvite to be enabled #1464

merged 6 commits into from
Apr 23, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Apr 16, 2024 •
edited by hannibal002
Loading

What

Allow party members to request allinvite to be enabled by doing !allinvite in party chat. Also added delay between doing some commands

Changelog New Features

  • Allow party members to request allinvite to be turned on. - CalMWolfs
    • Say !allinv in party chat for them to enable all invite.

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Apr 16, 2024
@CalMWolfs CalMWolfs added this to the Version 0.25 milestone Apr 16, 2024
@CalMWolfs CalMWolfs requested a review from nea89o April 16, 2024 10:14
@CalMWolfs CalMWolfs mentioned this pull request Apr 17, 2024
Merged
hannibal002
hannibal002 requested changes Apr 17, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also store if the party is currently enabled, otherwise this can have unintended behavior if sending !allinvite twice or two people sending it at the same time.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 23, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'beta' into fork/party-all-invite
a6985c8 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/commands/PartyChatCommands.kt
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 23, 2024
@hannibal002 hannibal002 merged commit c2a0e59 into hannibal002:beta Apr 23, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 23, 2024
@CalMWolfs CalMWolfs deleted the party-all-invite branch April 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@nea89o nea89o Awaiting requested review from nea89o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
3 participants
@CalMWolfs @nea89o @hannibal002