Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Highlight own Golden/Diamond Goblin #1466

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Feature: Highlight own Golden/Diamond Goblin #1466

merged 2 commits into from
Apr 17, 2024

Conversation

Thunderblade73
Copy link
Contributor

What

Highlights the own golden/diamond goblin in green.

Images

2024-04-16_17 30 38

Changelog New Features

  • Added option to highlight own Golden/Diamond Goblin. - Thunderblade73

Changelog Technical Details

  • Added direct support of setting the color of a mob. - Thunderblade73

@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 16, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 16, 2024
CalMWolfs
CalMWolfs requested changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also seeing as lastChatMessage and lastGoblinSpawn are set at the same point could they just be merged together?

src/main/java/at/hannibal2/skyhanni/features/mining/GoldenGoblinHighlight.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/GoldenGoblinHighlight.kt Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/mining/GoldenGoblinHighlight.kt Show resolved Hide resolved
@Thunderblade73
Copy link
Contributor Author

Problem is either chat is faster or the spawn, this way it does not matter which came first. And no they are not set at the same time.

@CalMWolfs
Copy link
Collaborator

Problem is either chat is faster or the spawn, this way it does not matter which came first. And no they are not set at the same time.

Oh i read farPast as now 😭

@CalMWolfs CalMWolfs self-requested a review April 17, 2024 12:25
@hannibal002 hannibal002 self-requested a review April 17, 2024 13:46
@hannibal002 hannibal002 merged commit 2d93420 into hannibal002:beta Apr 17, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 17, 2024
@Thunderblade73 Thunderblade73 deleted the golden-goblin branch April 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

@hannibal002 hannibal002 Awaiting requested review from hannibal002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
3 participants
@Thunderblade73 @CalMWolfs @hannibal002