Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add guide to dungeon hub races #1471

Merged
merged 10 commits into from
May 1, 2024

Conversation

catgirlseraid
Copy link
Contributor

@catgirlseraid catgirlseraid commented Apr 17, 2024

Dependencies

What

Add guide to dungeon hub races for all three races. Only works for Nothing; No return races

Images

image

Changelog New Features

  • Added dungeon hub race waypoints. - seraid
    • Only works for Nothing; No return races.

Changelog Technical Details

  • Added NamedParkourJson. - seraid

@hannibal002 hannibal002 added this to the Version 0.26 milestone Apr 17, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 23, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, except it breaks on every ability use (e.g. aote teleport). this is part of ParkourHelper, maybe you can fix it?

@CalMWolfs
Copy link
Collaborator

works fine, except it breaks on every ability use (e.g. aote teleport). this is part of ParkourHelper, maybe you can fix it?

In my opinion this is not a problem as the feature is not made to work for the later races. The whole feature is written to only work with Nothing at all; No return races. In these races you cannot use abilities so this will never break. This is made as just a little guide for beginners as once you are at the point of using abilities and pearls these waypoints do not provide much use.

@CalMWolfs CalMWolfs dismissed hannibal002’s stale review May 1, 2024 05:45

these things were added for a reason, i feel they should stay the way they are

@CalMWolfs CalMWolfs requested a review from hannibal002 May 1, 2024 05:45
@hannibal002 hannibal002 merged commit 2917930 into hannibal002:beta May 1, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 1, 2024
@catgirlseraid catgirlseraid deleted the dungeonracesguide branch July 18, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants