-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add guide to dungeon hub races #1471
Feature: add guide to dungeon hub races #1471
Conversation
src/main/java/at/hannibal2/skyhanni/data/jsonobjects/repo/NamedParkourJson.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine, except it breaks on every ability use (e.g. aote teleport). this is part of ParkourHelper, maybe you can fix it?
src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonsRaceGuide.kt
Show resolved
Hide resolved
In my opinion this is not a problem as the feature is not made to work for the later races. The whole feature is written to only work with Nothing at all; No return races. In these races you cannot use abilities so this will never break. This is made as just a little guide for beginners as once you are at the point of using abilities and pearls these waypoints do not provide much use. |
these things were added for a reason, i feel they should stay the way they are
Dependencies
What
Add guide to dungeon hub races for all three races. Only works for Nothing; No return races
Images
Changelog New Features
Changelog Technical Details