-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature + Fix: Player Chat Rework #1483
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/AdvancedPlayerList.kt
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small code things
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature seemed to work while standing in hub and playing around for 10 mins
What
Rewrote the entire "player chat" logic of SkyHanni, added many more settings to fine tune the look, and added more precise player chat events for the different channels (global, party, guild, etc.)
None of the existing features should have an impact.
Images
Changelog New Features
Changelog Improvements
Changelog Fixes
Changelog Technical Details
Changelog Removed Features