Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature + Fix: Player Chat Rework #1483

Merged
merged 50 commits into from
Apr 19, 2024
Merged

Feature + Fix: Player Chat Rework #1483

merged 50 commits into from
Apr 19, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Apr 18, 2024

What

Rewrote the entire "player chat" logic of SkyHanni, added many more settings to fine tune the look, and added more precise player chat events for the different channels (global, party, guild, etc.)
None of the existing features should have an impact.

Images

image

Changelog New Features

  • Option to reorder or hide every part of a player chat message. - hannibal2
    • Parts to move around: SkyBlock Level, Emblem, Player Name, Guild Rank, Private Island Rank, Crimson Faction, Iron Man Mode, Bingo Level and Private Island Guest.
    • Player messages impacted by this: all chat, party, guild, private chat, /show.
    • This might break hover/click on chat actions (Will be fixed later).
  • Hide Level Brackets. - hannibal2
    • Hide the gray brackets in front of and behind the level numbers.
  • Level Color As Name. - hannibal2
    • Use the color of the SkyBlock level for the player color.

Changelog Improvements

  • Added option Ignore YouTube. - hannibal2
    • Do not remove the rank for YouTubers in chat.
  • Added option Same Chat Color. - hannibal2
    • All players, also those with ranks, write with the same, white chat color.

Changelog Fixes

  • Fixed "chat rank hider" changing rank formatting for level 400+. - hannibal2

Changelog Technical Details

  • A ton. - hannibal2

Changelog Removed Features

  • Removing Player Chat Symbols. - hannibal2
    • This is now merged in "Part Order".

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 18, 2024
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 18, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs April 18, 2024 16:39
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 18, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/compacttablist/AdvancedPlayerList.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 18, 2024
@hannibal002 hannibal002 changed the title Feature: Player Chat Rework Feature + Fix: Player Chat Rework Apr 19, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small code things

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature seemed to work while standing in hub and playing around for 10 mins

@hannibal002 hannibal002 merged commit f8efe9e into beta Apr 19, 2024
7 checks passed
@hannibal002 hannibal002 deleted the player-chat-rework branch April 19, 2024 09:24
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants