Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Ability to adjust opacity of players near shared & guessed egg waypoints #1582

Merged
merged 9 commits into from
May 3, 2024
Merged

Feature: Ability to adjust opacity of players near shared & guessed egg waypoints #1582

merged 9 commits into from
May 3, 2024

Conversation

RobotHanzo
Copy link
Contributor

@RobotHanzo RobotHanzo commented Apr 28, 2024 •
edited by hannibal002
Loading

What

Feature: Ability to adjust opacity of players near shared & guessed egg waypoints (range: 4 blocks)

Images Default opacity: 100

image

Changelog New Features

  • Ability to adjust the opacity of players near shared and guessed egg waypoints. - RobotHanzo

hannibal002
hannibal002 requested changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, also works in game!
Please make sharedEggLocation and possibleEggLocations accessible outside the Egg Locator class, and move the new functions into a new class for maintainability.

@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 28, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 28, 2024
@RobotHanzo RobotHanzo requested a review from hannibal002 April 28, 2024 15:28
@RobotHanzo
Copy link
Contributor Author

The code looks fine, also works in game! Please make sharedEggLocation and possibleEggLocations accessible outside the Egg Locator class, and move the new functions into a new class for maintainability.

Done

@hannibal002
Copy link
Owner

next beta, sry

@hannibal002
Copy link
Owner

Well, too late for this feature now.
will test in next spring

@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Apr 29, 2024
@jani270 jani270 added Soon This Pull Request will be merged within the next couple of betas and removed Soon This Pull Request will be merged within the next couple of betas labels Apr 29, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 1, 2024
hannibal002
hannibal002 reviewed May 1, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss click :/

@hannibal002 hannibal002 self-requested a review May 1, 2024 09:01
hannibal002 added 2 commits May 1, 2024 12:14
@hannibal002
Merge branch 'beta' into fork/beta
d6ae03b 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
#	src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEggLocator.kt
#	src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityEggPlayerOpacityChanger.kt
@hannibal002
fixed merge conflicts
4fc1b27
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 2, 2024
@hannibal002
Merge branch 'beta' into fork/beta
e14fc86 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit 23a5bc7 into hannibal002:beta May 3, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martimavocado martimavocado martimavocado left review comments

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
4 participants
@RobotHanzo @hannibal002 @martimavocado @jani270