Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: More info on chocolate upgrades #1594

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Feature: More info on chocolate upgrades #1594

merged 7 commits into from
Apr 30, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Apr 30, 2024 •
edited by hannibal002
Loading

What

Extra tooltip stats about upgrades for the chocolate factory.

Images

Screenshot 2024-04-30 170101
Screenshot 2024-04-30 172637

Changelog New Features

  • Extra tooltip stats about upgrades for the chocolate factory. - CalMWolfs
    • View these to know when to buy time tower or Coach Jackrabbit.

Changelog Improvements

  • Live update chocolate amounts in other inventories related to the chocolate factory. - CalMWolfs

@CalMWolfs CalMWolfs marked this pull request as draft April 30, 2024 00:24
@CalMWolfs CalMWolfs marked this pull request as ready for review April 30, 2024 07:50
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Apr 30, 2024
@CalMWolfs CalMWolfs added this to the Version 0.25 milestone Apr 30, 2024
hannibal002
hannibal002 reviewed Apr 30, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
move all those slot indexes into a new object. maybe a map?
not very important, just an idea for the future

hannibal002
hannibal002 requested changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in game. maybe explain "effective cost" a bit more in the tooltip

src/main/java/at/hannibal2/skyhanni/features/event/chocolatefactory/ChocolateAmount.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/chocolatefactory/ChocolateAmount.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/chocolatefactory/ChocolateFactoryAPI.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/chocolatefactory/ChocolateFactoryTooltip.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/chocolatefactory/ChocolateFactoryTooltip.kt Outdated Show resolved Hide resolved
@hannibal002
Copy link
Owner

last commit message has a typo: "ignoredSlotIndexes changed from var to val"

hannibal002
hannibal002 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hannibal002 hannibal002 merged commit d595c90 into hannibal002:beta Apr 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 30, 2024
@CalMWolfs CalMWolfs deleted the chcolate-upgrade-info branch April 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
2 participants
@CalMWolfs @hannibal002