Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Mineshaft Pity Display + OreMinedEvent #1655

Merged
merged 120 commits into from
Jun 15, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented May 2, 2024

What

Adds a counter of your current pity counter for spawning a mineshaft. Also adds a OreMinedEvent that gets called when you mine a block using hypixel's custom mining system.

Images

image
image

Changelog New Features

  • Added Mineshaft Pity Display. - Empa
    • Displays information about Mineshaft spawns, your progress towards a Pity Mineshaft, and more.

Changelog Technical Details

  • Added OreBlock and OreType. - Empa
  • Added OreMinedEvent. - Empa
    • Provides information on the original block mined, and any other blocks mined by sources like Efficient Miner, Mole, etc.
  • Improved performance with Commission Color Blocks. - Empa

Thunderblade73 and others added 30 commits December 29, 2023 14:33
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
#	src/main/java/at/hannibal2/skyhanni/config/Storage.java
#	src/main/java/at/hannibal2/skyhanni/utils/StringUtils.kt
This reverts commit 2ed9de7.
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/Storage.java
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
Co-authored-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Co-authored-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 13, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/test/SkyHanniDebugsAndTests.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 13, 2024
Copy link

Conflicts have been resolved! 🎉

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing

src/main/java/at/hannibal2/skyhanni/data/MiningAPI.kt Outdated Show resolved Hide resolved
@ItsEmpa ItsEmpa requested a review from hannibal002 June 15, 2024 07:42
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@hannibal002 hannibal002 merged commit bfe43b7 into hannibal002:beta Jun 15, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 15, 2024
@ItsEmpa ItsEmpa deleted the mineshaft-pity-counter branch October 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants