Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Replace Roman Numerals with Arabic Numerals #1722

Merged
merged 3 commits into from
May 8, 2024
Merged

Feature: Replace Roman Numerals with Arabic Numerals #1722

merged 3 commits into from
May 8, 2024

Conversation

Mikecraft1224
Copy link
Contributor

@Mikecraft1224 Mikecraft1224 commented May 6, 2024 •
edited by hannibal002
Loading

What

Replaces Roman Numerals in almost all cases

  • Tooltips on item (enchants etc.)
  • Bestiary and Collections Milestones
  • Skills and Collections in chat

This might conflict with #1717 and will be tested.
This was tested, though there were issues found, they were not related with this feature.

Changelog New Features

  • Option to Replace Roman Numerals. - Mikecraft1224

@Mikecraft1224 Mikecraft1224 marked this pull request as ready for review May 8, 2024 08:57
@hannibal002 hannibal002 added this to the Version 0.25 milestone May 8, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 8, 2024
hannibal002
hannibal002 requested changes May 8, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plese move applyIfPossible into a utils class, and use it in PlayerChatModifier as well

src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java Outdated Show resolved Hide resolved
@Mikecraft1224 Mikecraft1224 requested a review from hannibal002 May 8, 2024 13:17
@hannibal002 hannibal002 merged commit bd117b2 into hannibal002:beta May 8, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikecraft1224 @hannibal002