Feature: Ghost Profit Tracker

[ItsEmpa]

Dependencies

• Ghost Profit Tracker Drops SkyHanni-REPO#271

What

WIP

Removes the Ghost Counter and replaces it with a Ghost Profit Tracker, to keep it consistent with other profit trackers, and to fix various issues with it.

TODO:

• Migrate data from ghost counter to ghost profit tracker
• Rename configs to ghost profit tracker
• Store allowed items in repo
• Remove old ghost counter code

Changelog New Features

• Added Ghost Profit Tracker. - Empa
  • Replaces the outdated and buggy Ghost Counter.

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

Conflicts have been resolved! 🎉

[hannibal002]

SkyHanni 0.28.Beta.12: Caught a RepoError in GhostTracker at RepositoryReloadEvent: Repo file 'constants/GhostDrops.json' not found.
 
Caused by at.hannibal2.skyhanni.data.repo.RepoError: Repo file 'constants/GhostDrops.json' not found.
	at SH.data.repo.RepoUtils.getConstant(RepoUtils.kt:98)
	at SH.features.combat.ghosttracker.GhostTracker.onRepoReload(GhostTracker.kt:397)
	at SH.data.repo.RepoManager.reloadRepository$lambda$9(RepoManager.kt:195)
	at SH.utils.DelayedRun.onThread$lambda$2(DelayedRun.kt:45)
	at SH.data.repo.RepoManager.reloadRepository(RepoManager.kt:189)
	at SH.data.repo.RepoManager.reloadLocalRepo(RepoManager.kt:96)
	at SH.config.commands.Commands.devTest$lambda$199$lambda$198(Commands.kt:631)
	at net.minecraftforge.client.ClientCommandHandler.executeCommand(ClientCommandHandler.java:72)
	at MC.client.gui.GuiScreen.sendChatMessage(GuiScreen.java:446)
	at MC.client.gui.GuiScreen.sendChatMessage(GuiScreen.java:437)
	at MC.client.gui.GuiChat.keyTyped(GuiChat.java:111)
	at MC.client.gui.GuiScreen.handleKeyboardInput(GuiScreen.java:578)
	at MC.client.gui.GuiScreen.handleInput(GuiScreen.java:534)
	at MC.client.Minecraft.runTick(Minecraft.java:1674)
	at MC.client.Minecraft.runGameLoop(Minecraft.java:1024)
	at MC.client.Minecraft.run(Minecraft.java:349)
	at MC.client.main.Main.main(Main.java:124)

[github-actions]

One or more Detekt Failures were detected:

• GhostTracker.kt#L120: Repo pattern itemDropPattern failed regex test: §5§l+20 Kill Combo §r§8§r§3+15☯ Combat Wisdom pattern: §6§lRARE DROP! §r§9(?<item>[^§]*) §r§b\([+](?:§.)*(?<mf>\d*)% §r§b✯ Magic Find§r§b\).

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[hannibal002]

the code looks good

but the kill detection doesnt work

[github-actions]

One or more Detekt Failures were detected:

• GhostTracker.kt#L235: The loop contains more than one break or continue statement. The code should be refactored to increase readability.

[github-actions]

One or more Detekt Failures were detected:

• GhostTracker.kt#L341: Missing newline after "{"