-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: reminder to open hoppity shop each year #1843
Conversation
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityNpc.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didnt see this before but it appears it doesnt check if it is currently spring, so this reminder would send when the npc isnt available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder works fine for me (look at cals suggestion), the detecton to stop reminding me after opening the shop works fine.
generally, this pr reminded me to buy them from shop at all, so thanks for that
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityNpc.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityNpc.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityNpc.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just this one thing i think
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityNpc.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
Conflicts have been resolved! 🎉 |
What
Adds a chat reminder to open the Hoppity Shop each SkyBlock year (stored per-profile). Can be disabled by clicking, like other SkyHanni reminders.
Appearance
Changelog New Features