Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: reminder to open hoppity shop each year #1843

Merged
merged 8 commits into from
May 29, 2024

Conversation

appable0
Copy link
Contributor

@appable0 appable0 commented May 20, 2024

What

Adds a chat reminder to open the Hoppity Shop each SkyBlock year (stored per-profile). Can be disabled by clicking, like other SkyHanni reminders.

Appearance Screenshot_2024-05-23_at_8 21 29_PM

Changelog New Features

  • Chat reminder to check Hoppity Shop each year. - appable

appable0 and others added 2 commits May 23, 2024 20:19
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@appable0 appable0 marked this pull request as ready for review May 24, 2024 03:25
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 24, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt see this before but it appears it doesnt check if it is currently spring, so this reminder would send when the npc isnt available

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder works fine for me (look at cals suggestion), the detecton to stop reminding me after opening the shop works fine.
generally, this pr reminded me to buy them from shop at all, so thanks for that

@hannibal002 hannibal002 added this to the Version 0.26 milestone May 24, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this one thing i think

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 29, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.java
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 29, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit f8d1275 into hannibal002:beta May 29, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants