Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: In Water Display #1892

Merged
merged 7 commits into from
May 30, 2024
Merged

Feature: In Water Display #1892

merged 7 commits into from
May 30, 2024

Conversation

Nealkitt
Copy link
Contributor

@Nealkitt Nealkitt commented May 25, 2024

What

Displays if the player is In Water for use with the Prismarine Blade/Shark Scale Armor, mostly useful on Stranded

Images

image
image

Changelog New Features

  • Added In-Water Display. - Stella
    • Useful when using a Prismarine Blade in Stranded Mode.

@hannibal002 hannibal002 added this to the Version 0.26 milestone May 26, 2024
@hannibal002
Copy link
Owner

please add more info to the changelog: why is this needed?

@Nealkitt
Copy link
Contributor Author

please add more info to the changelog: why is this needed?

Added that it's for stranded players

@martimavocado
Copy link
Contributor

changelog should look like this :3

+ Added In Water Display. - Stella
    * Useful while using Prismarine Blade in Stranded.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 30, 2024
@hannibal002 hannibal002 self-requested a review May 30, 2024 23:16
@hannibal002
Copy link
Owner

also jani does not like white guis

@hannibal002 hannibal002 merged commit 60cb082 into hannibal002:beta May 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 30, 2024
@Nealkitt Nealkitt deleted the water branch July 19, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants