Feature: Moveable and Scaleable Hotbar #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannibal002
added
the
Soon
CalMWolfs
requested changes
May 28, 2024
There was a problem hiding this comment.
feature works fine, just a bit of code cleanup.
Additionally, right now it defaults to the top left corner which I get why that is done but something that could be really cool is when turning on the feature for the first time (by checking if the position is set to the default position) it would calculate the current hotbar position and set its position to there, not necessary but would be cool
src/main/java/at/hannibal2/skyhanni/config/features/gui/HotbarConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/gui/MovableHotBar.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
…al config not loaded error on startup
hannibal002
approved these changes
May 29, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the hotbar to the gui editor. Will conflict with mods like Apec.
Has no fancy alignment, it is handle like every other gui element. I wouldn't rather add that option to all gui elements then specifically to that feature
Images
Changelog New Features