Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Jyrre Bottle and Cacao Truffle held time in lore #1916

Merged
merged 10 commits into from
May 30, 2024

Conversation

Obsidianninja11
Copy link
Contributor

@Obsidianninja11 Obsidianninja11 commented May 29, 2024

Dependencies

What

Shows the held time in lore of Bottles of Jyrre and Dark Cacao Truffles.
Also adds the option to show the dark cacao hours held as a stack size (same as existing bottle of jyrre stack size).

I think the name of the config might need to be changed. I couldn't come up with a good name for it (Currently Time Held in Lore).

Images

image
image
image

Changelog New Features

  • Added option to show time held in lore for Jyrre Bottles and Cacao Truffles. - Obsidian
  • Added Dark Cacao Truffle hours held as stack size. - Obsidian

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label May 29, 2024
@CalMWolfs CalMWolfs added this to the Version 0.26 milestone May 29, 2024
@Obsidianninja11 Obsidianninja11 requested a review from CalMWolfs May 29, 2024 04:43
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes look good, just that one thing

@CalMWolfs CalMWolfs mentioned this pull request May 29, 2024
@CalMWolfs CalMWolfs added Waiting on Dependency PR waiting for a dependency pr to be merged and removed Waiting on Dependency PR waiting for a dependency pr to be merged labels May 29, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more bit of code cleanup

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@Obsidianninja11 Obsidianninja11 requested a review from CalMWolfs May 29, 2024 22:58
@Obsidianninja11
Copy link
Contributor Author

Wait what
getting the config when not in sb could cause a crash?

@hannibal002 hannibal002 merged commit fca0126 into hannibal002:beta May 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label May 30, 2024
@CalMWolfs
Copy link
Collaborator

Wait what getting the config when not in sb could cause a crash?

It can, but it would require a tooltip event to be posted before config loads which is not possible

@hannibal002
Copy link
Owner

Wait what getting the config when not in sb could cause a crash?

LorenzToolTipEvent is safe to use here. But other events aren't. So It's better assume every event can crash, so it will never happen accidentally.

@Obsidianninja11 Obsidianninja11 deleted the jyrre-time-in-lore branch May 30, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants