-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Jyrre Bottle and Cacao Truffle held time in lore #1916
Feature: Jyrre Bottle and Cacao Truffle held time in lore #1916
Conversation
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all changes look good, just that one thing
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one more bit of code cleanup
src/main/java/at/hannibal2/skyhanni/features/inventory/HeldTimeInLore.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
Wait what |
It can, but it would require a tooltip event to be posted before config loads which is not possible |
LorenzToolTipEvent is safe to use here. But other events aren't. So It's better assume every event can crash, so it will never happen accidentally. |
Dependencies
What
Shows the held time in lore of Bottles of Jyrre and Dark Cacao Truffles.
Also adds the option to show the dark cacao hours held as a stack size (same as existing bottle of jyrre stack size).
I think the name of the config might need to be changed. I couldn't come up with a good name for it (Currently
Time Held in Lore
).Images
Changelog New Features