Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: mark duplicate egg locations #1929

Merged
merged 10 commits into from
May 30, 2024
Merged

Feature: mark duplicate egg locations #1929

merged 10 commits into from
May 30, 2024

Conversation

appable0
Copy link
Contributor

@appable0 appable0 commented May 29, 2024 •
edited by hannibal002
Loading

What

Marks duplicate egg locations in red when located using the Egglocator, Shared Egg Waypoints, or the Show All Waypoints feature. There is also an option to always mark nearby duplicate egg locations (within 10 blocks) in red.

Images Screenshot 2024-05-29 at 9 53 58 PM

Changelog New Features

  • Mark duplicate egg locations in red for unlocking some of the new rabbits. - appable
    • Option to always mark nearby duplicate egg locations.
  • Added "Collected Locations" line to the Unclaimed Eggs Display. - appable
    • This may be inaccurate if you've already collected eggs on an island.

@appable0 appable0 marked this pull request as draft May 29, 2024 22:25
CalMWolfs
CalMWolfs requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works completely fine, just a few things I noticed.

src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityUniqueEggLocations.kt Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityUniqueEggLocations.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/HoppityEggsConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/HoppityEggsConfig.java Outdated Show resolved Hide resolved
@appable0 appable0 marked this pull request as ready for review May 30, 2024 04:00
@hannibal002 hannibal002 added this to the Version 0.26 milestone May 30, 2024
@hannibal002 hannibal002 merged commit 47b1fdc into hannibal002:beta May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs requested changes

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
3 participants
@appable0 @hannibal002 @CalMWolfs