Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Item Pickup Log #1937

Merged
merged 36 commits into from
Jul 26, 2024
Merged

Conversation

catgirlseraid
Copy link
Contributor

@catgirlseraid catgirlseraid commented May 30, 2024

What

Item pickup log, also logs coins and sack items optionally. There are setting to choose how the user wants to align the log (ie add new items at the bottom, top, center) and options to compact the numbers, so they're easier to read. There is an option to live update (combine the + and minus amounts into a single line) or keep them seperate like sba.

Images

image

Changelog New Features

  • Added Item Pickup Log. - catgirlseraid

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 30, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002 hannibal002 added this to the Version 0.27 milestone May 30, 2024
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 30, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 13, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

blahajenjoyer7 added 3 commits July 14, 2024 16:01
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
#	src/main/java/at/hannibal2/skyhanni/config/features/inventory/InventoryConfig.java
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 14, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 17, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found multiple spots where I think stuff happens unnecessary, or we already have working solutions for the problem.

@hannibal002 hannibal002 merged commit 3cbb6b8 into hannibal002:beta Jul 26, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 26, 2024
Nealkitt pushed a commit to Nealkitt/SkyHanni that referenced this pull request Sep 8, 2024
Co-authored-by: SeRaid <77941535+SeRaid743@users.noreply.github.com>
Co-authored-by: blahajenjoyer7 <171753706+blahajenjoyer7@users.noreply.github.com>
@catgirlseraid catgirlseraid deleted the item-pickup-log branch October 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants