Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Cleanup some scoreboard event stuff #1940

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented May 30, 2024

What

Cleanup some scoreboard event stuff.

  • Made the name of the event be in line with other similar Skyhanni events
  • removed the old scoreboard from the event because it was never used and really should never be used
  • renamed the event parameter to make more sense

Not exactly sure why RawScoreboardUpdateEvent is needed, but i dont have rift slayer unlocked so it stays for now

Changelog Technical Details

  • Cleaned up some scoreboard event handling. - CalMWolfs

@CalMWolfs CalMWolfs added the Backend A backend pull request that will be merged soon label May 30, 2024
@CalMWolfs CalMWolfs added this to the Version 0.26 milestone May 30, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 5, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/BitsAPI.kt
#	src/main/java/at/hannibal2/skyhanni/data/PurseAPI.kt
Copy link

github-actions bot commented Jun 5, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Jun 5, 2024
Copy link

github-actions bot commented Jun 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/ScoreboardData.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

Conflicts have been resolved! 🎉

Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 15, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/MiningAPI.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 16, 2024
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 self-requested a review June 16, 2024 16:16
@hannibal002 hannibal002 merged commit b81197a into hannibal002:beta Jun 16, 2024
4 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Jun 16, 2024
@CalMWolfs CalMWolfs deleted the cleanup-scoreboard branch September 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants