Feature: Golden Fish Timer #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
CalMWolfs
requested changes
May 30, 2024
src/main/java/at/hannibal2/skyhanni/features/fishing/trophy/GoldenFishTimer.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
CalMWolfs
approved these changes
May 31, 2024
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…timer # Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt # src/main/java/at/hannibal2/skyhanni/features/fishing/FishingAPI.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…timer # Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…timer # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/fishing/FishingAPI.kt
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/fishing/FishingBaitWarnings.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
added
the
Soon
|
idk what i am doing wrong. either the 3 minutes delay are wrong. or you need to fish something, not throw the rod in. |
|
i think the most likely reason is that the detection for wheter or not something actually counts as throwing rod is really weird |
…entory and having at least fished once
|
oje |
hannibal002
removed
the
Soon
Signed-off-by: ItsEmpa <itsempa@users.noreply.github.com>
jani270
added
the
Soon
hannibal002
approved these changes
Sep 10, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a Golden Fish Timer, with info on how long it has been since the last rod, time until you can spawn one, etc.
Also adds options to, for example, show certain info as a nametag on top of the golden fish, highlight it when its ready and give a warning when you are close to the time limit of throwing rod.
Images
Changelog New Features