Feature: "Not any pests" chat filter and "No pests!" title #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
requested changes
May 31, 2024
src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/pests/PestFinder.kt
Outdated
Show resolved
Hide resolved
CalMWolfs
requested changes
Jun 1, 2024
src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/pests/PestFinder.kt
Outdated
Show resolved
Hide resolved
CalMWolfs
approved these changes
Jun 1, 2024
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/chat/ChatFilter.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
jani270
added
the
Soon
github-actions
bot
removed
the
Soon
MTOnline69
pushed a commit
to MTOnline69/SkyHanni
that referenced
this pull request
Sep 11, 2024
…02#1957) Co-authored-by: Cal <cwolfson58@gmail.com> Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a filter which hides the "not any pests" message. Also adds a "No Pests!" title, which triggers when you use the Pest Tracker with no pests on your garden. Those features can be used separately.
Images
Changelog New Features