Improvement + Fix: Barn Fishing Timer #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
…hing-timer # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/fishing/FishingTimer.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
|
the scope of this pr has changed to also implement the sea creature cap changes added by hypixel |
hannibal002
changed the title
hannibal002
requested changes
Jul 26, 2024
There was a problem hiding this comment.
i dont understand why we process magma slugs differently. also the custom handlinb of fishing mobs should maybe get moved into another api class, so that only the count and add logic remains in this class. (extract complexitiy that might be duplicated in future other features into abstract classes early)
src/main/java/at/hannibal2/skyhanni/features/fishing/FishingTimer.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/fishing/FishingTimer.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/fishing/FishingTimer.kt
Outdated
Show resolved
Hide resolved
hannibal002
approved these changes
Jul 26, 2024
Nealkitt
pushed a commit
to Nealkitt/SkyHanni
that referenced
this pull request
Sep 8, 2024
Co-authored-by: Cal <cwolfson58@gmail.com> Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com> Co-authored-by: ItsEmpa <itsempa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors Barn Fishing Timer to use MobDetection, adds a warning for when you reach a certain amount of sea creatures, and makes the time actually based on the time each mob has existed for instead of the time the timer has been active for.
This pr now also makes changes to the barn fishing timer to work with the new fishing cap changes Hypixel implemented.
Changelog Improvements
Changelog Fixes