Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add chocolate production time for stray rabbits #1978

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented Jun 2, 2024

What

Show the chocolate production time for stray/golden rabbits caught in the chocolate factory menu.

  • New config option (added below duplicate rabbit time since they are somewhat related) to toggle this feature on/off
  • Added regex tests to find chocolate gained from stray/golden rabbits
  • Following format from duplicated rabbits (in chat message) but instead shown as a tooltip beside the stray rabbit caught
  • Not adding regex pattern for Fish the Rabbit since it adds a new rabbit instead of giving chocolates (except duplicate, but handled by duplicate rabbit time already)
  • I have tested the code and confirmed that it works (except golden rabbits since hobbity hunt event is currently inactive, but the pattern has been added)

Refer to attached images for an example tooltip.

Images Screenshot

Changelog New Features

  • Added stray/golden chocolate rabbit production time. - sayomaki

@CalMWolfs CalMWolfs self-requested a review June 3, 2024 05:10
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Jun 3, 2024
@CalMWolfs CalMWolfs added this to the Version 0.26 milestone Jun 3, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me (I did 2 small fixes)

@hannibal002 hannibal002 merged commit a7ecc57 into hannibal002:beta Jun 9, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants