Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Favorite Power Stones #2002

Merged
merged 13 commits into from
Jun 5, 2024
Merged

Feature: Favorite Power Stones #2002

merged 13 commits into from
Jun 5, 2024

Conversation

saga-00
Copy link
Contributor

@saga-00 saga-00 commented Jun 4, 2024 •
edited by hannibal002
Loading

What

Highlights your favorite power stones. You can add/remove them with Shift Click.

Images

image

Changelog New Features

  • Added Favorite Power Stones. - saga
    • Highlighted in the Thaumaturgy inventory.
    • Shift-click to add/remove them.

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 4, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 4, 2024
saga-00 and others added 3 commits June 4, 2024 23:00
@saga-00 @CalMWolfs
Update src/main/java/at/hannibal2/skyhanni/config/features/inventory/…
640bcfd 
…InventoryConfig.java

Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
@saga-00
Update FavoritePowerStone.kt
a090c63
@saga-00
Update FavoritePowerStone.kt
91c6078
@saga-00 saga-00 requested a review from CalMWolfs June 5, 2024 02:05
hannibal002
hannibal002 requested changes Jun 5, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in game. Just several smaller code cleanup ideas, and one minor bug.

src/main/java/at/hannibal2/skyhanni/features/inventory/FavoritePowerStone.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/FavoritePowerStone.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/FavoritePowerStone.kt Show resolved Hide resolved
saga-00 added 3 commits June 5, 2024 10:58
@saga-00
fixes
7a907ac
@saga-00
Merge remote-tracking branch 'origin/favoritePowerStone' into favorit…
f48df64 
…ePowerStone

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/inventory/FavoritePowerStone.kt
@saga-00
fixes2
b6b05df
@saga-00 saga-00 requested a review from hannibal002 June 5, 2024 14:14
hannibal002
hannibal002 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@hannibal002 hannibal002 merged commit 93229bf into hannibal002:beta Jun 5, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 5, 2024
@saga-00 saga-00 deleted the favoritePowerStone branch June 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
3 participants
@saga-00 @hannibal002 @CalMWolfs