Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Make build fail on wrong annotation #2024

Merged
merged 6 commits into from
Jun 8, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Jun 8, 2024

What

Make build fail when event functions have wrong annotation. This is because while both our own live plugin and the minecraft development plugin give warnings when you have the wrong annotation, neither of them will actually stop the build from finishing, and the build task that is run on prs does not get far enough into launching that it will crash. This means if a branch is updated and the person doesnt launch it, they will not know that it breaks. As we switch over events to the new system this makes it so that if I or another contributor updates a pr we can tell immediately that it does not build and needs attention making it so that we can identify prs that need fixing quicker.

Example error message:

w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from Event because it is annotated with @SubscribeEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent
w: [ksp] Function in at.hannibal2.skyhanni.features.inventory.HarpFeatures must have an event assignable from SkyHanniEvent because it is annotated with @HandleEvent

Changelog Technical Details

  • Make build fail when event functions have wrong annotation. - CalMWolfs

@CalMWolfs CalMWolfs marked this pull request as ready for review June 8, 2024 05:45
@CalMWolfs CalMWolfs added the Bug Fix Bug fixes label Jun 8, 2024
@CalMWolfs CalMWolfs added this to the Version 0.26 milestone Jun 8, 2024
@hannibal002 hannibal002 self-requested a review June 8, 2024 08:23
@hannibal002 hannibal002 merged commit ad3ee80 into hannibal002:beta Jun 8, 2024
3 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jun 8, 2024
@CalMWolfs CalMWolfs deleted the crash-on-wrong-annotation branch June 8, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants