Backend: Make build fail on wrong annotation #2024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make build fail when event functions have wrong annotation. This is because while both our own live plugin and the minecraft development plugin give warnings when you have the wrong annotation, neither of them will actually stop the build from finishing, and the build task that is run on prs does not get far enough into launching that it will crash. This means if a branch is updated and the person doesnt launch it, they will not know that it breaks. As we switch over events to the new system this makes it so that if I or another contributor updates a pr we can tell immediately that it does not build and needs attention making it so that we can identify prs that need fixing quicker.
Example error message:
Changelog Technical Details