Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Compact Chat for Garden Visitor Reward Summary #2026

Merged
merged 16 commits into from
Jun 9, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jun 8, 2024

What

Add a toggle-able option to allow compacting the summary message when accepting offers from visitors in the Garden.

Images

Option itself, nested within Garden > Visitors

Opt


Hover to view full message.

Compacted_1


Non-standard rewards will have their full name printed.

Compacted_2


Pattern matching designed to work with all current offered rewards, as well as upcoming rewards currently in Alpha (fine flour, for example).

Compacted_3

Changelog New Features

  • Added toggle for compacting Garden visitor summary messages. - Daveed

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 8, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 8, 2024
@hannibal002 hannibal002 self-requested a review June 8, 2024 07:24
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly fine, thanks for this feature!

I found a bunch of code cleanup things to change. If you need any clarification, please ask! (feel free to ping me in discord)

image

@hannibal002 hannibal002 merged commit a8222b7 into hannibal002:beta Jun 9, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants