Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Compact Pattern Matching on Legendary+ Rabbits #2041

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jun 8, 2024

Dependencies

See #1923 for original context, or the reported issue here: https://discord.com/channels/997079228510117908/1245403391639949464

What

Fix the pattern matching to correctly identify Legendary rabbits while compacting.

Images

Old expression against legendary test-case.
image

New expression against legendary test-case.
image

New expression against non-legendary test-case.
image

Changelog Fixes

  • Fixed compact chat sometimes breaking when obtaining legendary or higher tier rabbits. - Daveed

@CalMWolfs CalMWolfs added this to the Version 0.26 milestone Jun 9, 2024
@CalMWolfs CalMWolfs merged commit 60db3c6 into hannibal002:beta Jun 9, 2024
3 checks passed
@DavidArthurCole DavidArthurCole deleted the LegRabbitCompactFix branch June 9, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants