Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Add event inheritance #2047

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Backend: Add event inheritance #2047

merged 11 commits into from
Oct 11, 2024

Conversation

ThatGravyBoat
Copy link
Contributor

@ThatGravyBoat ThatGravyBoat commented Jun 9, 2024 •
edited by CalMWolfs
Loading

What

Adds back event class inheritance as previously not included in #2008
This will create an event handler on the first post of an event and will include all listeners from all super classes.

The changes can be viewed in this commit c41bc1b
This PR also contains moving WorldClickEvent to SkyHanniEvent to demonstrate this.

Changelog Technical Details

  • Added SkyHanni event inheritance. - ThatGravyBoat

@hannibal002
Copy link
Owner

@nea89o would love to see your feedback on this

@hannibal002 hannibal002 added this to the Version 0.27 milestone Jun 11, 2024
@btwonion
Copy link

should this pr also port all existing events to SkyHanniEvent or should this pr only implement the concept?

@hannibal002
Copy link
Owner

The bigger the pr, the harder to test and review.
I think we can move old prs over to the new system slowly and later, first we need the new system working

@CalMWolfs
Copy link
Collaborator

should this pr also port all existing events to SkyHanniEvent or should this pr only implement the concept?

This would be a change of ~3000 additons & 3000 deletions

@btwonion
Copy link

I see. The system works for me as of now. Is it only the reviewing holding on the pr or are there still things to be implemented?

@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
@ThatGravyBoat
Merge branch 'main-beta' into backend/event-inheritance
5e202bb 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/api/event/EventHandler.kt
#	src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonHighlightClickedBlocks.kt
@ThatGravyBoat
Clean up merge
92f69a7
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 11, 2024
@ThatGravyBoat
Copy link
Contributor Author

Please Hanni merge 🥺

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 21, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@CalMWolfs CalMWolfs self-requested a review October 8, 2024 11:06
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 8, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 8, 2024
CalMWolfs
CalMWolfs approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me in my testing

@hannibal002 hannibal002 merged commit 60f92d5 into hannibal002:beta Oct 11, 2024
4 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@ThatGravyBoat @hannibal002 @btwonion @CalMWolfs