Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Anniversary Custom Scoreboard #2058

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix: Anniversary Custom Scoreboard #2058

merged 4 commits into from
Jun 12, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Jun 11, 2024 •
edited
Loading

What

Fixes the anniversary line in scoreboard not being detected

Changelog Fixes

  • Fixed Anniversary Line not being detected in Custom Scoreboard. - Empa, j10a1n15

ItsEmpa added 3 commits June 11, 2024 18:08
@ItsEmpa
anniversary scoreboard
10514d1 
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@ItsEmpa
,
326e17f 
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@ItsEmpa
regex test
5d48495 
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@ItsEmpa ItsEmpa marked this pull request as draft June 11, 2024 16:27
@j10a1n15 @ItsEmpa
fix
0e5ba27 
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
j10a1n15
j10a1n15 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@j10a1n15 j10a1n15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undraft it, and ready to go

@ItsEmpa ItsEmpa marked this pull request as ready for review June 11, 2024 16:38
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 11, 2024
@hannibal002 hannibal002 added the Bug Fix Bug fixes label Jun 11, 2024
hannibal002
hannibal002 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the countdown in the custom scoreboard sometimes skips a second, then later stays on the same second for two seconds. not ideal. this is a problem of the general update delay, i suppose. outside of this pr.

works fine enough for now

src/main/java/at/hannibal2/skyhanni/utils/CollectionUtils.kt Show resolved Hide resolved
@hannibal002 hannibal002 merged commit 4b3caa4 into hannibal002:beta Jun 12, 2024
4 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jun 12, 2024
@ItsEmpa ItsEmpa deleted the fix/scoreboard-anniversary branch June 13, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j10a1n15 j10a1n15 j10a1n15 approved these changes

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
3 participants
@ItsEmpa @hannibal002 @j10a1n15