Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement + Fix: Unclaimed Eggs feature while busy #2091

Merged

Conversation

Obsidianninja11
Copy link
Contributor

@Obsidianninja11 Obsidianninja11 commented Jun 14, 2024

What

Changes show during contest for Unclaimed Eggs gui to show while busy. (it was impossible to see while in the rift, etc.)
Adds an additional option for warning while busy.

Untested. should work, but idk if i did config migration correctly.

kinda bad changelogs (duplicate busy descriptions)

Changelog Improvements

  • Separate option for Unclaimed Eggs warning while "Busy". - Obsidian
    • In the Rift, Kuudra, Dungeons, etc.

Changelog Fixes

  • Allow seeing the unclaimed eggs GUI while "Busy". - Obsidian
    • In the Rift, Kuudra, Dungeons, etc.

@hannibal002
Copy link
Owner

You would leave rift for eggs?

@hannibal002
Copy link
Owner

Or other: are there other activities you might want to get interrupted during, where we could fix this? I dont like adding a global "ignore buzy check" feature if this only impacts 2-3 of those

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 14, 2024
@Obsidianninja11
Copy link
Contributor Author

Obsidianninja11 commented Jun 16, 2024

Why would anyone not want to see the gui while in the rift or kuudar or something? (Idk why it was ever hidden during these in the first place)
There's an option to not send the warning doing these (this is what shouldve gotten the isbusy check before imo).

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 30, 2024
@hannibal002 hannibal002 changed the title Improvement: Unclaimed Eggs feature while busy Improvement + Fix: Unclaimed Eggs feature while busy Jul 2, 2024
@hannibal002 hannibal002 added Bug Fix Bug fixes and removed Soon This Pull Request will be merged within the next couple of betas labels Jul 2, 2024
@hannibal002 hannibal002 merged commit a30e243 into hannibal002:beta Jul 6, 2024
4 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jul 6, 2024
@Obsidianninja11 Obsidianninja11 deleted the show-unclaimed-eggs-while-busy branch October 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants