Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Compact Hoppity Chat for Purchased Rabbits #2100

Merged
merged 6 commits into from
Jun 15, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jun 14, 2024

What

Reported by Luna here: https://discord.com/channels/997079228510117908/1251294395140145322

The issue stemmed from having no capturing for the case where a rabbit is purchased from hoppity, so the chats were allowed through. This PR addresses that while leaving all other aspects untouched.

The main issue, and reason for the complexity of the comment in the new reset call, is that when finding a meal egg, the "you found [meal egg]" is the first message in the chain, whereas when purchasing, the "you bought [rabbit]" message is the last in the chain, so a new flow had to be designed.

Images

image

Changelog Fixes

  • Fixed Compact Hoppity Chat not working with rabbits purchased from the Hoppity NPC. - Daveed

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 15, 2024
@hannibal002 hannibal002 self-requested a review June 15, 2024 00:40
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannibal002 hannibal002 merged commit e0f3a5e into hannibal002:beta Jun 15, 2024
4 checks passed
@DavidArthurCole DavidArthurCole deleted the PurchaseHoppityCompact branch July 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants