Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hoppity Requirement when already found. #2101

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jun 15, 2024

What

Hypixel allows purchasing Rabbits from Hoppity NPC even when the requirement is not yet met.
Fixed highlight wrong missing requirement.

Changelog Fixes

  • Fixed highlight missing requirements even when Hoppity Rabbit is already found. - hannibal2

@hannibal002 hannibal002 added the Bug Fix Bug fixes label Jun 15, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 15, 2024
@Obsidianninja11
Copy link
Contributor

I'm kinda against this.
The requirement and it being "found" (by buying) are kind of unrelated.
This could be kind of misleading if it's merged

(but also this is so minor i don't think it's a big deal if it goes either way)

@CalMWolfs
Copy link
Collaborator

I'm kinda against this.

The requirement and it being "found" (by buying) are kind of unrelated.

This could be kind of misleading if it's merged

(but also this is so minor i don't think it's a big deal if it goes either way)

There is really no reason to get the requirement once you already have the rabbit. Unless hypixel fixes the bug and removes "illegally" gotten rabbits there is no reason for this or not to be merged

@hannibal002 hannibal002 merged commit 3a16949 into beta Jun 15, 2024
9 checks passed
@hannibal002 hannibal002 deleted the fix-wrong-missing-requirement-display branch June 15, 2024 09:22
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants