Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add Keybinds to Custom Wardrobe #2105

Merged

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Jun 15, 2024

What

This Pull Request adds custom wardrobe slot keybinds to skyhanni, only while in the custom wardrobe.

Warning

You somehow are able to use this, even when the config to use custom keybinds or even the custom wardrobe is disabled?
It like straight up ignores the config values
image

Nevermind, I want to die, I had neu's keybinds enabled

Changelog Improvements

  • Added Custom Wardrobe Slot Keybinds. - j10a1n15
    • These function independently of NEU. NEU's keybinds will not work in the Custom Wardrobe.

j10a1n15 added 4 commits June 15, 2024 17:00
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 16, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 16, 2024
@hannibal002 hannibal002 self-requested a review June 16, 2024 15:31
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannibal002 hannibal002 merged commit e9ea84e into hannibal002:beta Jun 16, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 16, 2024
@j10a1n15 j10a1n15 deleted the improvement/custom-wardrobe-keybinds branch June 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants