Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Time Tower Reminder feature #2133

Merged
merged 11 commits into from
Jun 23, 2024
Merged

Feature: Time Tower Reminder feature #2133

merged 11 commits into from
Jun 23, 2024

Conversation

appable0
Copy link
Contributor

@appable0 appable0 commented Jun 20, 2024 •
edited by hannibal002
Loading

What

Removes and replaces "Time Tower Reminder" feature. The original intent of the feature is not longer needed based on my testing:

Test duration: 4500 seconds

Theoretical chocolate gained if TT:
- doesn't work offline: 112,572,000
- works offline: 144,432,000

Experimental:
Starting chocolate: 284,023,769
Ending chocolate: 428,688,227
Chocolate gained: 144,664,458

This feature now sends a single notification when the time tower expires and there are remaining charges.

Image Screenshot 2024-06-20 at 11 04 54 PM

Changelog New Features

  • Add reminder that the Time Tower is expired and has extra charges available. - appable
    • Replaces the previous Time Tower Reminder feature.

Changelog Removed Features

  • Remove the original Time Tower Reminder feature. - appable
    • Hypixel now correctly calculates Time Tower offline.

@appable0 appable0 marked this pull request as ready for review June 21, 2024 06:04
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 21, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 21, 2024
@hannibal002 hannibal002 self-requested a review June 22, 2024 07:59
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'refs/heads/beta' into fork/appable0/remove-time-tower-r…
37054a0 
…eminder

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryTimeTowerManager.kt
@hannibal002
formatting
4afae21
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 22, 2024
@hannibal002 hannibal002 merged commit b08dc62 into hannibal002:beta Jun 23, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jun 23, 2024
@hannibal002 hannibal002 changed the title Replace: Time Tower Reminder feature Feature: Time Tower Reminder feature Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 Awaiting requested review from hannibal002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
2 participants
@appable0 @hannibal002