Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Line to Nukekebi Skull #2148

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Jun 25, 2024

What

This Pull Request adds a line to the enderman slayer nukekebi skull.
Discord

Images

2024-06-25_17 32 58
2024-06-25_17 32 59

Changelog New Features

  • Add a line to Nukekebi Skull. - j10a1n15

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jun 25, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jun 25, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position seems off to me
image

hannibal002 and others added 2 commits June 30, 2024 12:26
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line is still not centered.
It looks like the skull is not the head of the armor stand, rather the item in hand?

@ItsEmpa
Copy link
Contributor

ItsEmpa commented Jun 30, 2024

shouldnt the position of it be the same place as the string?

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>
@hannibal002 hannibal002 merged commit d635862 into hannibal002:beta Jul 6, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 6, 2024
@j10a1n15 j10a1n15 deleted the feature/line-to-nukekebi branch July 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants