Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: RecalculatingValue as a ReadOnlyProperty #2151

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Jun 25, 2024

What

Makes RecalculatingValue be a ReadOnlyProperty, so that it can be used as a property delegate, so you dont need to call .getValue() to use it. Also makes its usages be done like this.

Changelog Technical Details

  • Made RecalculatingValue a ReadOnlyProperty. - Empa

ItsEmpa added 2 commits June 25, 2024 21:31
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 7, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkyHanni 0.26.Beta.12: Caught an NullPointerException in SlayerAPI at LorenzTickEvent: null
 
Caused by java.lang.NullPointerException: null
	at SH.utils.RecalculatingValue.getValue(RecalculatingValue.kt:18)
	at SH.utils.RecalculatingValue.getValue(RecalculatingValue.kt:22)
	at SH.data.SlayerAPI.getActiveSlayer(SlayerAPI.kt:85)
	at SH.data.SlayerAPI.onTick(SlayerAPI.kt:126)
	at SH.data.MinecraftData.onTick(MinecraftData.kt:76)
	at FML.common.eventhandler.EventBus.post(EventBus.java:140)

Signed-off-by: Empa <42304516+ItsEmpa@users.noreply.github.com>
@hannibal002 hannibal002 merged commit ba091f8 into hannibal002:beta Jul 15, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 15, 2024
@ItsEmpa ItsEmpa deleted the backend/recalculating-value branch October 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants