-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Powder Mining Chat Filter V2 #2152
Improvement: Powder Mining Chat Filter V2 #2152
Conversation
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningFilterConfig.java
Outdated
Show resolved
Hide resolved
This is completely dead code now that Hypixel changed all their messages. |
This is good to go again. The only slight "nice-to-have" that would be left to do if desired would be re-adding some indication of what the non-filtered results are pertaining to. Before the formatting change from Hypixel everything had the provided context of "You received..." but now, the unfiltered rewards are just left by themselves in chat. |
@hannibal002 Just finished my last rounds of verification. It might be worth bumping this up towards 0.26 instead of 0.27, as the current filter is no longer at all functional, and this would be fixing that as well. I can update chglog if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we need options for every different gemstone type. this feels like a waste of config space, and makes setting up stuff complicated for users. Also harder to maintain. (you dont need to remove it, im just curious)
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningGemstoneFilterConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningChatFilter.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/chat/PowderMiningGemstoneFilterConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/chat/FilterTypesConfig.java
Outdated
Show resolved
Hide resolved
@hannibal002 All requested changes have been addressed in latest commits. Re: Gemstone config, due to gemstones having different values, seems worth it to have separate configs for each, however if its wanted to flatten that down into one config, I can. |
Dependencies
Possibly dependent on #2143 due to previous changes being made
What
Overhaul the Powder Mining filter to allow individual addressing of each type of drop that can come from chests. What was previously a boolean "enabled" now maps to the overall "filter enabled" boolean in the accordion. More complicated options (goblin eggs, gemstones) were given custom enum types for determining functionality.
Images
Changelog Improvements