Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Powder Mining Chat Filter V2 #2152

Merged
merged 26 commits into from
Jul 30, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jun 25, 2024

Dependencies

Possibly dependent on #2143 due to previous changes being made

What

Overhaul the Powder Mining filter to allow individual addressing of each type of drop that can come from chests. What was previously a boolean "enabled" now maps to the overall "filter enabled" boolean in the accordion. More complicated options (goblin eggs, gemstones) were given custom enum types for determining functionality.

Images

image

image

Changelog Improvements

  • Overhauled the Powder Mining chat filter to be much more customizable. - Daveed

@hannibal002 hannibal002 added this to the Version 0.27 milestone Jun 26, 2024
@DavidArthurCole
Copy link
Contributor Author

This is completely dead code now that Hypixel changed all their messages.
Guess it's time for me to redo everything.

@DavidArthurCole DavidArthurCole marked this pull request as draft July 15, 2024 18:45
@DavidArthurCole
Copy link
Contributor Author

image

@DavidArthurCole DavidArthurCole marked this pull request as ready for review July 15, 2024 22:22
@DavidArthurCole
Copy link
Contributor Author

This is good to go again. The only slight "nice-to-have" that would be left to do if desired would be re-adding some indication of what the non-filtered results are pertaining to.

Before the formatting change from Hypixel everything had the provided context of "You received..." but now, the unfiltered rewards are just left by themselves in chat.

@DavidArthurCole
Copy link
Contributor Author

Rewards that make it through the filter will now get reformatted to be a lot more readable, and it be much more clear where they came from.
image

@DavidArthurCole
Copy link
Contributor Author

@hannibal002 Just finished my last rounds of verification. It might be worth bumping this up towards 0.26 instead of 0.27, as the current filter is no longer at all functional, and this would be fixing that as well. I can update chglog if necessary.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 21, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need options for every different gemstone type. this feels like a waste of config space, and makes setting up stuff complicated for users. Also harder to maintain. (you dont need to remove it, im just curious)

@DavidArthurCole
Copy link
Contributor Author

@hannibal002 All requested changes have been addressed in latest commits.

Re: Gemstone config, due to gemstones having different values, seems worth it to have separate configs for each, however if its wanted to flatten that down into one config, I can.

@hannibal002 hannibal002 merged commit 2968287 into hannibal002:beta Jul 30, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 30, 2024
@DavidArthurCole DavidArthurCole deleted the PowderFilterV2 branch July 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants