Fix: Farming Weight Overtake ETA

[evhan3584]

PR Reviews

When your PR is marked as ready for review, some of our maintainers will look through your code to make sure everything is good to go. In order to do this, they may request some changes you will need to do, or fix smaller stuff (like merge conflicts) for you. If a maintainer has reviewed your PR, make sure to pull any of their changes into your local project before doing more work on your code. Having maintainers fix small stuff for you helps us speed up the process of merging your PR, so if some of your systems warrant further care, be sure to let us know (preferably with a code comment).

Make sure to only mark your PR as "Ready to review" when it is. If you still want to do major changes, you can keep a draft PR open until then.

What

This is a simple fix to the Farming Weight Overtake ETA.

Changelog Fixes

• Fix an issue where the farming overtake ETA was being displayed as 60 times longer than it actually was. - Evhan_

[evhan3584]

I frequently encounter the following error:

 
Caused by java.lang.IllegalArgumentException: Duration value cannot be NaN.
	at kotlin.time.DurationKt.toDuration(Duration.kt:1131)
	at SH.features.garden.farming.FarmingWeightDisplay.getETA(FarmingWeightDisplay.kt:313)
	at SH.features.garden.farming.FarmingWeightDisplay.update(FarmingWeightDisplay.kt:204)
	at SH.features.garden.farming.FarmingWeightDisplay.onTick(FarmingWeightDisplay.kt:81)
	at SH.data.MinecraftData.onTick(MinecraftData.kt:76)
	at FML.common.eventhandler.EventBus.post(EventBus.java:140)

Extra data:
weightPerSecond: 'NaN'
weightUntilOvertake: '2247.192604832075'
totalWeight: '320.29089239432443'
nextPlayer.weight: '2567.4834972264'

It appears that the issue is mitigated by replacing line 387 with the following code:

weightPerSecond = (weightDiff / diff * speed / 1000).let { if (it.isNaN()) -1.0 else it }

I suspect that diff can sometimes be set as NaN or 0 by GardenCropMilestoneDisplay. Should I include this change in my PR?