Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Estimated Item Value #2180

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Improvement: Estimated Item Value #2180

merged 3 commits into from
Jul 6, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jul 1, 2024 •
edited
Loading

Changelog Improvements

  • Update Estimated Item Value calculation. - hannibal2
    • Change attribute prices from composited to the lowest bin, and added an option to use composited prices again.
    • Add Toxophilite.
    • Add option to choose whether to use Bazaar buy order or instant buy prices.
    • Calculating with tier 5 prices for Ferocious Mana, Hardened Mana, Mana Vampire and Strong Mana.

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 1, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 1, 2024
@hannibal002 hannibal002 requested a review from CalMWolfs July 1, 2024 10:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 2, 2024
@hannibal002
Merge branch 'refs/heads/beta' into estimated-item-value-update
d04b296 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValueCalculator.kt
@hannibal002
fixed merge conflicts
e4724eb
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 merged commit 34ba8c5 into beta Jul 6, 2024
9 checks passed
@hannibal002 hannibal002 deleted the estimated-item-value-update branch July 6, 2024 05:57
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
1 participant
@hannibal002