Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Thunder Bottle Charged Notification #2234

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Feature: Thunder Bottle Charged Notification #2234

merged 7 commits into from
Jul 28, 2024

Conversation

raaaaaven
Copy link
Contributor

@raaaaaven raaaaaven commented Jul 17, 2024 •
edited by hannibal002
Loading

What

Added title notification for when thunder bottles charge.
I just placed it below replace roman numerals, couldn't think of a better spot.

Changelog New Features

  • Added a title notification for when the Thunder Bottle is fully charged. - raven

@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 19, 2024
Thunderblade73
Thunderblade73 suggested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature looks fine. I don't like it that it is in misc. But there is also not really a better place for it.
Only thing that needs to be done is to address the 2 small code changes.

src/main/java/at/hannibal2/skyhanni/features/misc/ThunderBottleNotification.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/ThunderBottleNotification.kt Outdated Show resolved Hide resolved
raaaaaven and others added 2 commits July 24, 2024 22:11
@raaaaaven @Thunderblade73
Update src/main/java/at/hannibal2/skyhanni/features/misc/ThunderBottl…
6d40700 
…eNotification.kt

Co-authored-by: Thunderblade73 <85900443+Thunderblade73@users.noreply.github.com>
@raaaaaven
make isEnabled() private
a0d1d8f
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 28, 2024
@hannibal002 hannibal002 merged commit 32d3a6a into hannibal002:beta Jul 28, 2024
3 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Jul 28, 2024
@raaaaaven raaaaaven deleted the thunderbottles branch July 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j10a1n15 j10a1n15 j10a1n15 approved these changes

@Thunderblade73 Thunderblade73 Thunderblade73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.26
Development

Successfully merging this pull request may close these issues.
4 participants
@raaaaaven @j10a1n15 @Thunderblade73 @hannibal002