Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Accessory MP as stack size #2243

Merged
merged 34 commits into from
Sep 7, 2024
Merged

Feature: Accessory MP as stack size #2243

merged 34 commits into from
Sep 7, 2024

Conversation

minhperry
Copy link
Contributor

@minhperry minhperry commented Jul 20, 2024 •
edited by hannibal002
Loading

What

https://discord.com/channels/997079228510117908/1263951633059156009

Images

image

image

image

Changelog New Features

  • Added Accessory magical power display as stack size. - minhperry
    • Only works inside the Accessory Bag and Auction House.

hannibal002
hannibal002 requested changes Jul 21, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr! the code looks good overall, still needs some polishing.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/misc/MPDisplayConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/misc/MPDisplayConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 21, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jul 21, 2024
@minhperry minhperry requested a review from hannibal002 July 21, 2024 15:34
@minhperry minhperry marked this pull request as draft July 22, 2024 22:14
@minhperry
Copy link
Contributor Author

adding support for abicases for now

@minhperry
Copy link
Contributor Author

for some reasons the "Auctions: *" regex would just never pass despite passing IJ tester

image

@minhperry minhperry marked this pull request as ready for review July 24, 2024 11:34
@minhperry
Copy link
Contributor Author

image

Is this intended it just spams my email with this

Thunderblade73
Thunderblade73 suggested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I late to this. But what the isAccessory function does should already be done by the itemCategory code. If it isn't for some wierd reason / edge case, please let me know and I will fix it.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
Thunderblade73
Thunderblade73 suggested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code structure is good. But you missed some stuff that is mostly unqiue to our repo (eg: pattern for mostly everything). I also added some formatting stuff that makes the code look better.

src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/inventory/MagicalPowerConfig.java Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/MagicalPowerDisplay.kt Outdated Show resolved Hide resolved
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Jul 31, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Aug 21, 2024
@minhperry minhperry requested a review from hannibal002 August 24, 2024 02:48
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Aug 26, 2024
@hannibal002 hannibal002 merged commit 4663ebc into hannibal002:beta Sep 7, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Sep 7, 2024
MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024
@minhperry @hannibal002 @MTOnline69
Feature: Accessory MP as stack size (hannibal002#2243)
9931d83 
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaynx lunaynx lunaynx requested changes

@Thunderblade73 Thunderblade73 Thunderblade73 requested changes

@j10a1n15 j10a1n15 j10a1n15 requested changes

@ThatGravyBoat ThatGravyBoat ThatGravyBoat left review comments

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.27
Development

Successfully merging this pull request may close these issues.
6 participants
@minhperry @hannibal002 @ThatGravyBoat @j10a1n15 @Thunderblade73 @lunaynx