Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dicer Tracker Reset Button #2248

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix: Dicer Tracker Reset Button #2248

merged 1 commit into from
Jul 28, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Jul 21, 2024

What

Fixed Dicer Tracker Reset Button being misaligned.
Reported: https://discord.com/channels/997079228510117908/1250100311108882433 (This is another bug)

Changelog Fixes

  • Fixed Dicer Tracker Reset Button misalignment. - hannibal2

@hannibal002 hannibal002 added the Bug Fix Bug fixes label Jul 21, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 21, 2024
@hannibal002 hannibal002 changed the title Fixed Dicer Tracker Reset Button being misaligned. Fix: Dicer Tracker Reset Button Jul 21, 2024
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix did not work. Also see no reason why it should work.
image

@Thunderblade73
Copy link
Contributor

The problem is here: SkyHanniTracker L91
renderStringsAndItems does not work with elements that have a y size that is different from 10

@hannibal002
Copy link
Owner Author

This pr does not fix the bug linked to the discord report, but rather fixes another bug. (see changelog text)

@hannibal002 hannibal002 merged commit ed61531 into beta Jul 28, 2024
11 checks passed
@hannibal002 hannibal002 deleted the dicer-tracker-bug branch July 28, 2024 08:33
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants