Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hoppity Abiphone Call Compact #2250

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jul 22, 2024

What

Update the blocking of hoppity compacting so that it is not dependent on it being a hoppity's event. Since hoppity can call outside of the event, this caused compacting to break for abiphone calls.

Since the UI there is just a re-skinned version of what you get when you buy rabbits from hoppity normally, no other code changes were needed, as the existing Bought rabbit! code will detect it (see image).

Images

image

Changelog Fixes

  • Fixed Hoppity Chat Compact not working outside of Hoppity's event for Abiphone users who have Hoppity as a contact. - Daveed

@github-actions github-actions bot added the Bug Fix Bug fixes label Jul 22, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone Jul 22, 2024
@hannibal002 hannibal002 merged commit bde6b2a into hannibal002:beta Jul 26, 2024
5 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Jul 26, 2024
@DavidArthurCole DavidArthurCole deleted the CompactHoppityCalls branch July 26, 2024 12:07
Nealkitt pushed a commit to Nealkitt/SkyHanni that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants